Skip to content

fix: handle errors in destroy #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2019
Merged

fix: handle errors in destroy #1106

merged 4 commits into from
Jan 20, 2019

Conversation

eddyerburgh
Copy link
Member

  • Throw if error thrown when instance destroyed

Fixes #1105

@eddyerburgh eddyerburgh merged commit efab983 into vuejs:dev Jan 20, 2019
@eddyerburgh eddyerburgh deleted the handle-errors-in-destroy branch January 20, 2019 11:18
@Haroenv
Copy link
Contributor

Haroenv commented Jan 20, 2019

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyerburgh @Haroenv